Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public facing id of project to be the id of the submission #3944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theskumar
Copy link
Member

Update the project urls to use it's submission id instead of the project's db id

The reason for the update is that there are two main entities in the system, one submission and other project.
The ids of the submission is linkable in the communiction and also used for referencing at different places.

Considering a project is an extension of application submission, if we have the project publically available id same as that of it's submission it always to link and reference the project by the same id.

Test Steps

  • General regression test and make sure all the urls in the project section resolve and link to the right pages

@theskumar theskumar self-assigned this May 28, 2024
@theskumar theskumar mentioned this pull request Sep 21, 2024
7 tasks
Copy link
Member

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase. Would be good to get this in, it's the right approach I think.

@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants