Update makefile, auto-help and better serve #4109
Conversation
|
@frjo thanks for the quick review, I've update the PR with a bigger refractor to
|
theskumar
force-pushed
the
improve-makefile
branch
from
e1dd555 to
097f646
Compare
Makefile
Outdated
| $(MAKE) -j3 watch serve-django serve-docs | ||
| serve: .cache/tandem .cache/py-packages .cache/dev-build ## Run Django and docs preview server, also watch and compile frontend changes | ||
| @.cache/tandem \ | ||
| 'python manage.py runserver 0.0.0.0:$(DJANGO_PORT) --settings=$(DJANGO_SETTINGS_MODULE)' \ |
There was a problem hiding this comment.
Switch to runserver_plus? We already have "Werkzeug" installed. Nice error handling!
Should we also switch to 127.0.0.1 instead of 0.0.0.0? Do devs ever access the server from other devices on the LAN?
There was a problem hiding this comment.
We can switch to 127.0.0.1, generally it's useful to test on phone, and I had that as default. I rarely use it, so I think it's safe to switch.
There was a problem hiding this comment.
For runserver_plus I think we can.
The current make -j parallelization doesn't kill the remaining process when one of them errors out, the causes confusion if let's css/js is not building. This PR also refractors the help target to use comment based generator which is more maintainable.
Also, remove collectstatic during dev
frjo
force-pushed
the
improve-makefile
branch
from
4e729f6 to
8de43fb
Compare
|
@theskumar I merged this is but added a small change as well. Please test to make sure it works. I added a address to the port for runserver_plus. This makes the test server link in the terminal clickeble, I find this convenient.
|
|
Also added a way to pick up address set as env var, |
…pdate-test-packages * origin/main: Fix js error when no proposal field on determination form. (#4147) Fix 'Reminder Created' duplicate message, restrict duplicate toast messages (#4126) Rename past submission to other submissions (#4143) Add content from Hypha site to docs front page. (#4139) Lock griffe version, breaking change in v1.x. (#4138) Update micromatch. (#4137) Added command to delete drafts that haven't been modified in specified days (#4133) Updated the sandbox db. (#4135) Updated the sandbox db. (#4132) Update PAF to Project Form in user facing strings (#4104) Add invoice date and paid date to invoice and invoices lists and tables (#4019) Added links & icons to wagtail form view `Used By` columns (#4106) New submission table view (#4080) Update makefile, auto-help and better serve (#4109)
The current make -j parallelization doesn't kill the remaining process when one of them errors out, the causes confusion if let's css/js is not building.
This PR also refractors the help target to use comment based generator which is more maintainable.
Update the node scripts to not require
collectstaticduring development, the runserver -> static server can find all the all files from packages and serve them on demand.make servenow also installs python & node packages and builds the static_src if they are outdated.