Improve cloned forms naming #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes-otf
added
Type: Enhancement
frjo
approved these changes
Sep 9, 2024
frjo
added
Status: Needs testing
theskumar
approved these changes
Sep 9, 2024
theskumar
reviewed
Sep 9, 2024
hypha/apply/funds/utils.py
Outdated
| @@ -159,3 +162,29 @@ def is_filter_empty(filter: filters.FilterSet) -> bool: | |||
|
|
|||
| # Flatten the QueryDict values in filter.data to a single list, check for validity with any() | |||
| return any(reduce(iconcat, [param[1] for param in query.lists()], [])) | |||
|
|
|||
|
|
|||
| def get_copied_form_name(orignal_form_name: str) -> str: | |||
There was a problem hiding this comment.
can i suggest adding some quick unit test for this util. esp. the regex pattens I don't trust them too much.
theskumar
previously requested changes
Sep 9, 2024
|
@theskumar unit tests added in the last commit - was trying to find a way to patch/mock |
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs user testing 👷
sandeepsajan0
pushed a commit
that referenced
this pull request
Oct 18, 2024
Fixes #3546 Improves the naming of cloned forms by changing the format to `<original form name> (Copied on <%Y-%m-%d %H:%M:%S.%f>)`, ie. cloning `Test Form` would result in a duplicated form with the name `Test Form (Copied on 2024-08-27 17:34:32.004)`. If a form name with a timestamp already exists on a form it will be subbed via RegEx matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3546. Improves the naming of cloned forms by changing the format to
<original form name> (Copied on <%Y-%m-%d %H:%M:%S.%f>), ie. cloningTest Formwould result in a duplicated form with the nameTest Form (Copied on 2024-08-27 17:34:32.004). If a form name with a timestamp already exists on a form it will be subbed via RegEx matching.Test Steps
(Copied on <%Y-%m-%d %H:%M:%S.%f>)appended to it