Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fund -> workflow module #4318

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Refactor fund -> workflow module #4318

merged 4 commits into from
Jan 10, 2025

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Jan 3, 2025 •
edited
Loading

  • Refactor workflow.py to break it down into smaller modules
  • Rename funds.workflow -> funds.workflows
  • Improvement to Documentation
  • Remove unused constant declationDETERMINATION_PHASES

@theskumar theskumar self-assigned this Jan 3, 2025
@theskumar theskumar force-pushed the refactor-workflow branch 2 times, most recently from a3add79 to 7f309b1 Compare January 4, 2025 16:37
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 7, 2025
frjo
frjo approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As intended it seems to have zero effect, everything works just as before.

This makes the workflows a lot more manageable. As discussed, there are more changes we should do to them, this is a first good step.

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 9, 2025
@wes-otf
Copy link
Contributor

wes-otf commented Jan 9, 2025

In my other testing today I haven't seen anything deviate & code looks good!

@frjo frjo force-pushed the refactor-workflow branch from a60dad4 to e3625bd Compare January 10, 2025 08:50
@frjo frjo temporarily deployed to test-hypha-app January 10, 2025 08:52 Inactive
@frjo frjo merged commit fa7302c into main Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wes-otf wes-otf wes-otf approved these changes

@frjo frjo frjo approved these changes

@sandeepsajan0 sandeepsajan0 Awaiting requested review from sandeepsajan0

Assignees

@theskumar theskumar

Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theskumar @wes-otf @frjo