Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for DjangoMessagesAdapter #4350

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Remove need for DjangoMessagesAdapter #4350

merged 7 commits into from
Feb 3, 2025
+165 −163

Conversation

frjo
Copy link
Member

@frjo frjo commented Jan 20, 2025 •
edited
Loading

Fixes #4344

The following messages in DjangoMessagesAdapter() has been replaced with direct calls to messages.* or by using SuccessMessageMixin.

MESSAGES.BATCH_REVIEWERS_UPDATED
MESSAGES.BATCH_TRANSITION
MESSAGES.BATCH_DETERMINATION_OUTCOME
MESSAGES.REMOVE_DOCUMENT
MESSAGES.SKIPPED_REPORT
MESSAGES.REPORT_FREQUENCY_CHANGED
MESSAGES.DISABLED_REPORTING
MESSAGES.CREATE_REMINDER
MESSAGES.DELETE_REMINDER

Test Steps

  • …

@frjo frjo changed the title Rebuild create and detele reminders messages. Remove need for DjangoMessagesAdapter Jan 20, 2025
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Jan 21, 2025
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 31, 2025
@frjo frjo merged commit 257c1ac into main Feb 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team Status: Needs testing Tickets that need testing/qa Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use messages.add_message() directly and remove DjangoMessagesAdapter
1 participant
@frjo