Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: use the new "standardized" petab_select classes #1530

Merged
merged 37 commits into from
Jan 11, 2025

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Nov 29, 2024

Will not merge until the next PEtab Select release

  • update petab-select version in setup.cfg

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (e9a969e) to head (bd01ad8).

Files with missing lines Patch % Lines
pypesto/visualize/select.py 37.50% 5 Missing ⚠️
pypesto/select/postprocessors.py 50.00% 3 Missing ⚠️
pypesto/select/method.py 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1530      +/-   ##
===========================================
- Coverage    84.37%   84.33%   -0.05%     
===========================================
  Files          163      163              
  Lines        14037    13987      -50     
===========================================
- Hits         11844    11796      -48     
+ Misses        2193     2191       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl mentioned this pull request Dec 9, 2024
@dilpath dilpath marked this pull request as ready for review January 4, 2025 17:08
@dilpath dilpath changed the title Select: use the new petab_select.Models class Select: use the new "standardized" petab_select classes Jan 4, 2025
@dilpath dilpath mentioned this pull request Jan 9, 2025
Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the changes a lot. Much nicer to use

doc/example/model_selection.ipynb Outdated Show resolved Hide resolved
doc/example/model_selection.ipynb Show resolved Hide resolved
doc/example/model_selection.ipynb Outdated Show resolved Hide resolved
pypesto/select/postprocessors.py Show resolved Hide resolved
pypesto/select/problem.py Show resolved Hide resolved
pypesto/select/problem.py Outdated Show resolved Hide resolved
pypesto/visualize/select.py Outdated Show resolved Hide resolved
Copy link
Contributor

@stephanmg stephanmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes wrt visualization look fine to me. Thanks for the contribution.

@dilpath dilpath added this pull request to the merge queue Jan 10, 2025
@dilpath dilpath removed this pull request from the merge queue due to a manual request Jan 10, 2025
@dilpath dilpath enabled auto-merge January 10, 2025 22:31
@dilpath dilpath added this pull request to the merge queue Jan 11, 2025
Merged via the queue into develop with commit 9f0b6f1 Jan 11, 2025
18 checks passed
@dilpath dilpath deleted the select_class_models branch January 22, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants