Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cardapi): Passage de la card API téléchargement en premier #25 #28

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Naminoshin
Copy link
Collaborator

Description

This PR introduces [...]

Architectural changes

The following library now depends on [...]

Screenshots

[...]

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

@Naminoshin Naminoshin requested a review from mmohadIGN June 13, 2024 13:12
Copy link

Affected libs: api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, feature-editor, api-repository, feature-catalog, feature-auth, ui-search, common-domain, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, data-access-datafeeder, util-data-fetcher, data-access-gn4, util-app-config, util-i18n,
Affected apps: datahub, metadata-converter, metadata-editor, demo, webcomponents, search, map-viewer, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link

📷 Screenshots are here!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai un doute. S'il ne valait pas mieux modifier le has usage. Je le note pour réflexion, mais je valide là pr

@mmohadIGN mmohadIGN merged commit d8efc95 into Api_telechargement Jun 13, 2024
3 of 6 checks passed
@Naminoshin Naminoshin deleted the api_telechargement_25 branch June 26, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants