Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T&A: 43407: Fix missing StatusOfAttempt #8823

Open
wants to merge 2 commits into
base: release_10
Choose a base branch
from

Conversation

lukas-heinrich
Copy link
Contributor

Hi everyone,

this PR refers to the ticket 43407, which describes an incorrect display of the Status Of Attempts.

The behavior described can be traced back to the fact that the object's properties are not set at any point, which I have added. Setting StatusOfAttempt::RUNNING at this point may look irritating. When debugging, however, I was able to determine that the getAttemptOverviewInformation() method is not executed if there is no pass. Accordingly, it can be assumed that the status at this point is at least Running or that the test run has already been completed.

I look forward to your feedback and am open to suggestions or questions. This PR was co-authored and internally reviewed by @thojou.

Best,
@lukas-heinrich

@thojou thojou requested a review from kergomard January 10, 2025 13:19
@thojou thojou added bugfix php Pull requests that update Php code labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants