Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Typst v0.12, string/content panic fixes and ToC #16

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

LordBaryhobal
Copy link
Contributor

@LordBaryhobal LordBaryhobal commented Nov 23, 2024

This PR bumps the Typst version used by the template to v0.12, as well as the latest versions of imported packages (codelst, showybox and acrostiche)

It fixes the new context warnings, improves some syntax formatting in the template itself, and fixes issues with figure captions. The latter was solved by removing eval calls in favor of letting the user pass content as parameters (title, sub-title, captions, etc.)

There are still some questions left:

@LordBaryhobal LordBaryhobal changed the title Updated to Typst v0.12 and fixed string/content panics [WIP] Updated to Typst v0.12 and fixed string/content panics Nov 23, 2024
@pmudry
Copy link
Collaborator

pmudry commented Nov 24, 2024

Regarding #15, it can be made here as well, even though I'd rather have more explicit names than tol``tofetc.

@pmudry
Copy link
Collaborator

pmudry commented Nov 24, 2024

Version can be bumped to 0.1.6 as the other features are still not implemented. In any case, thank you 👏🏻 very much @LordBaryhobal for the update. Once the PR has been merged and the latest points merged, I will then push to the official Typst repository.

@pmudry pmudry marked this pull request as ready for review November 24, 2024 17:15
@LordBaryhobal LordBaryhobal changed the title [WIP] Updated to Typst v0.12 and fixed string/content panics Updated to Typst v0.12 and fixed string/content panics Nov 25, 2024
@LordBaryhobal LordBaryhobal changed the title Updated to Typst v0.12 and fixed string/content panics Updated to Typst v0.12, string/content panic fixes and ToC Nov 25, 2024
@LordBaryhobal
Copy link
Contributor Author

LordBaryhobal commented Nov 25, 2024

I have added a tables parameter which lets the user choose which outline to include
Let me know if that meets your expectations

NB: I've changed the header version to 0.1.6 alpha, so it will need to be changed to omega when publishing to Typst Universe

@pmudry
Copy link
Collaborator

pmudry commented Nov 25, 2024

I have added a tables parameter which lets the user choose which outline to include Let me know if that meets your expectations

NB: I've changed the header version to 0.1.6 alpha, so it will need to be changed to omega when publishing to Typst Universe

Perfect, merging as is ! Thank you very much ! I'll let you know when updated in the official Typst Universe

@pmudry pmudry closed this Nov 25, 2024
@LordBaryhobal
Copy link
Contributor Author

Perfect 👍
It seems you closed it instead of merging it however

@pmudry pmudry reopened this Nov 25, 2024
@pmudry pmudry merged commit c365362 into ISC-HEI:master Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants