Query::assembleSelect(): Apply orderBy before joining the relations
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix/order-by
branch
from
1fbf51e to
5affbdd
Compare
Otherwise, the query fails if `Query::orderBy()` contain relations that are not present in `Query::$with`. - Previously, `Query::order()` enhanced the `Query::$with` array, but the enhanced values were no longer taken into account for joining relations.
sukhwinder33445
force-pushed
the
fix/order-by
branch
from
5affbdd to
8f69a07
Compare
nilmerg
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the query fails if
Query::orderBy()contain relations that are not present inQuery::$with.Query::order()enhanced theQuery::$witharray, but the enhanced values were no longer taken into account for joining relations.