remove double logging from the web api layer

IdentityServer · Jan 15, 2017 · e434539 · e434539
1 parent 9b33d32
commit e434539
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/source/Core/Configuration/Hosting/ErrorPageFilterAttribute.cs b/source/Core/Configuration/Hosting/ErrorPageFilterAttribute.cs
@@ -31,8 +31,6 @@ internal class ErrorPageFilterAttribute : ExceptionFilterAttribute
 
         public override async System.Threading.Tasks.Task OnExceptionAsync(HttpActionExecutedContext actionExecutedContext, System.Threading.CancellationToken cancellationToken)
         {
-            Logger.ErrorException("Exception accessing: " + actionExecutedContext.Request.RequestUri.AbsolutePath, actionExecutedContext.Exception);
-
             var env = actionExecutedContext.ActionContext.Request.GetOwinEnvironment();
             var options = env.ResolveDependency<IdentityServerOptions>();
             var viewSvc = env.ResolveDependency<IViewService>();

diff --git a/source/Core/Configuration/Hosting/LogProviderExceptionLogger.cs b/source/Core/Configuration/Hosting/LogProviderExceptionLogger.cs
@@ -30,7 +30,15 @@ internal class LogProviderExceptionLogger : IExceptionLogger
 
         public async Task LogAsync(ExceptionLoggerContext context, CancellationToken cancellationToken)
         {
-            Logger.ErrorException("Unhandled exception", context.Exception);
+            if(context.Request != null)
+            {
+                var mesage = string.Format("Unhandled exception accessing: {0}", context.Request.RequestUri.AbsolutePath);
+                Logger.ErrorException(mesage, context.Exception);
+            }
+            else
+            {
+                Logger.ErrorException("Unhandled exception", context.Exception);
+            }
 
             var env = context.Request.GetOwinEnvironment();
             var events = env.ResolveDependency<IEventService>();