Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login status to navbar and modify logo sizing #25

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

ashleyyli
Copy link

@ashleyyli ashleyyli commented Oct 27, 2024

Status:

Description

Added login status to Navbar and modified mobile navbar logo sizing. Non-logged in users will see "Hello, guest user!".

Closes #

Screenshots

Screenshot 2024-11-03 at 11 04 14

@ashleyyli ashleyyli requested a review from firmianaw October 27, 2024 19:17
Copy link
Contributor

@firmianaw firmianaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you resolve the 'names' is possibly undefined check error and change the formatting so that there's no background and the font is the same as the rest of the navbar?

@firmianaw firmianaw merged commit a1f27ed into main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants