-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SAUtils for Cosmic #63
Open
heseber
wants to merge
19
commits into
Illumina:main
Choose a base branch
from
heseber:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Cosmic releases use a different column name for the Cosmic ID. This is now fixed. The cancer type count and cancer site count were based on study id. This does not make sense, because we want to have the number of tumours where a mutation is found, not the number of studies. For now, I just replaced the study id column tag with the name of the tumour id column. Addtional refactoring would be needed to rename all references to _study_ with _tumour_.
Do not drop counts of cancer type, cancer site, and tier completely if just some of the tumors do not have them annotated.
Histologies and Sites were returned as IList<string> but could never have more than one list item. This was new simplified to having just a single string for each of Histology, Site and Tier.
Replace underscores with spaces in tumor sites and types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current COSMIC releases have a slightly modified format of the TSV files. Some column headers have changed (e.g.,
Mutation ID
->GENOMIC_MUTATION_ID
, and a newTier
column was added.Counts for CancerType and CancerSite were based on study identifiers, not on tumor identifiers. This does not really make sense, because we want to know the number of tumors per cancerType and cancerSite, not the number of studies (a study can have many different tumors of the same type and site). Furthermore, the study id column is often empty if a PubMed id is specified instead.
This pull request updates the SAUtils for Cosmic to make it work with current Cosmic releases and also changes the counts to refer to tumors instead of studies. This is only for short variants, not for structural variants and fusions.
Here is an example output (just the "cosmic" section, and after pretty-printing with jq, of course):