Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add doobie support #184

Merged
merged 5 commits into from
Nov 6, 2023
Merged

feature: Add doobie support #184

merged 5 commits into from
Nov 6, 2023

Conversation

vbergeron
Copy link
Contributor

Add integration with the doobie data access library.

@Iltotore Iltotore added this to the 2.4.0 milestone Oct 27, 2023
Iltotore
Iltotore previously approved these changes Nov 1, 2023
View reviewed changes
doobie/src/io/github/iltotore/iron/doobie.scala Outdated Show resolved Hide resolved
@Iltotore Iltotore dismissed their stale review November 3, 2023 07:09

Wrong action (should be "changes requested)

Iltotore
Iltotore requested changes Nov 3, 2023
View reviewed changes
Copy link
Owner

@Iltotore Iltotore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use _root_.doobie instead to avoid cyclic reference. See other modules (like cats.scala) for example.

@vbergeron vbergeron requested a review from Iltotore November 6, 2023 14:04
@Iltotore Iltotore merged commit 6b969dc into Iltotore:main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iltotore Iltotore Iltotore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vbergeron @Iltotore @vbergeron-ledger