Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1566 storybook consistency and UI enhancement #1640

Open
wants to merge 153 commits into
base: master
Choose a base branch
from

Conversation

evangeliaPanteliadou
Copy link
Collaborator

@evangeliaPanteliadou evangeliaPanteliadou commented Dec 10, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Storybook: consistency and UI enhancement #1566

📦 Published PR as canary version: 30.9.2--canary.1640.e43988106d4b26dd629292540be9d5e4b6980d07.1

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@30.9.2--canary.1640.e43988106d4b26dd629292540be9d5e4b6980d07.1
# or 
yarn add @infineon/infineon-design-system-stencil@30.9.2--canary.1640.e43988106d4b26dd629292540be9d5e4b6980d07.1

agata-kim and others added 30 commits November 14, 2024 16:25
…s. Fixed bug with inverted spinner in Spinner component.
github-actions and others added 29 commits January 2, 2025 12:53
@fapfaff
Copy link

fapfaff commented Jan 9, 2025

Looks already way better than before!
But here are a few things that I still would change:

General

Sometimes theres the Usage page first, and sometimes the Development page.
It would be nice if it would be consistent.

Accordion

  • mutable: Improve description

Card

  • alt: not updating

Chip

  • AriaLabel: Sets "arialabel" instead of aria-label
  • selected: not updating

Date-Picker

  • name: not updating
  • min/max: description should mention that it needs to be formatted as yyyy-mm-dd
  • aria-label: not updating
  • target: Should be a single select control in storybook

Footer

  • A basic story control for socials and links would be nice

Navbar

  • ifxNavbarMobileMenuIsOpen: event missing
  • target: Should be a single select control in storybook

Sidebar

  • target: Should be a single select control in storybook

Search Bar

  • disabled: Update description
  • isOpen: Update description

Single Select

  • many props missing

Slider

  • minValueHandle/maxValueHandle missing

Table (Advanced)

  • show-loading: not updating

Table (Basic)

  • rowHeight: not updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook: consistency and UI enhancement
4 participants