Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CRUD from database option GUI ... Update builder.blade.php #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aramics
Copy link

@Aramics Aramics commented Oct 14, 2019

Generate from Database Option GUI

Generate from Database Option GUI
@Aramics Aramics changed the title Update builder.blade.php Generate CRUD from database option GUI ... Update builder.blade.php Oct 14, 2019
@ajayinfyom ajayinfyom self-requested a review October 19, 2019 05:54
@ajayinfyom
Copy link
Contributor

Hi @Aramics nice work.

but there need to some refactor.

  1. Select only one table at time from drop down instant of multiple tables and generate scaffold for single table.
  2. Model Name option should be there and its required.
    everyone not want same Model name as table name.
  3. Remove commented code like var_dump

btw, You can Put all things in single PR with all changes like route, builder.blade & controller, no need to put separate PRs.

@Aramics
Copy link
Author

Aramics commented Oct 19, 2019

Thanks for being welcoming @ajayinfyom .
Why do you prefer single table scaffolding ? Is it because of the model name ?
if Yes , table UI could be with respective model name i.e select box with alternative text box infront for model name if table name is not desired.

if No, then please make clear why since you know every bit of the code .
Multiple table scaffolding could be every helpful.

Thanks.

@ajayinfyom
Copy link
Contributor

@Aramics Its fine to generate scaffold with multiple tables at a time.

but , i see here generated model name smaller & plural case.
Modal name Must be Singular and Capitalised.
Can you please make this changes ?

@ajayinfyom
Copy link
Contributor

@Aramics Its fine to generate scaffold with multiple tables at a time.

but , i see here generated model name smaller & plural case.
Modal name Must be Singular and Capitalised.
Can you please make this changes ?

i fixed that things in second PR : 10f2a97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants