chore: perp markets token metadata #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
denom
for the base symbol. We just know thebase symbol
, and we're trying to derive the token metadata fromtoken-metadata
package usingDenomClient.getDenomToken
in the same way that we would if we were trying to derive the metadata via passing the denom. This leads to edge cases and complexityDenomClient.getTokenMetaDataBySymbol
and then adding a few required fields to return a properToken
type. Note that it seems like the only useful fields for a derivative base token is thename
/symbol
/logo
properties. The rest don't seem to be used, which is why I feel like the simplification I'm making here with the newgetDerivativesToken
could be justifiedNote
Placed this in draft because we should test some more before merging, but I'm curious your thoughts on this approach