fix: ibc metadata fetch error handling #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-moore
commented
Feb 14, 2024
| @@ -50,6 +50,9 @@ jobs: | |||
| env: | |||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
|
|
|||
| - name: Get IBC Tokens | |||
| run: yarn --cwd packages/sdk-ui-ts get-ibc-tokens || true | |||
There was a problem hiding this comment.
the || true will make the build continue even if error occurs when running get-ibc-tokens script
shane-moore
commented
Feb 14, 2024
|
|
||
| const response = (await Promise.race([ | ||
| ibcTokenMetadataResponse, | ||
| timeout(2000), |
There was a problem hiding this comment.
if response from ibc token metadata fetch takes longer than 2 seconds, the timeout function will throw an error, which will just get logged in the catch block below. then, build should continue
There was a problem hiding this comment.
We can pass second parameter to HttpRestClient { timeout: 2000 } and have the same logic as you implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.