Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update mito indexer vesion #524

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

ThomasRalee
Copy link
Collaborator

@ThomasRalee ThomasRalee commented Dec 3, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced data structure for IDO transformations with new fields: isPermissionless and projectDescription.
  • Bug Fixes
    • Updated dependency version for improved stability and potential bug fixes in the @injectivelabs/mito-proto-ts package.

Copy link

coderabbitai bot commented Dec 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request includes updates to the @injectivelabs/sdk-ts package, specifically modifying the package.json file to bump the version of the @injectivelabs/mito-proto-ts dependency from 1.13.0 to 1.13.2. Additionally, it enhances the MitoIDO data structure by adding two new properties, isPermissionless and projectDescription, to the return type of the mitoIDOToIDO method in the IndexerGrpcMitoTransformer class. Corresponding changes are also made to the MitoIDO interface to accommodate these new fields.

Changes

File Path Change Summary
packages/sdk-ts/package.json Updated dependency @injectivelabs/mito-proto-ts from 1.13.0 to 1.13.2.
packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcMitoTransformer.ts Added isPermissionless and projectDescription fields to the return type of mitoIDOToIDO.
packages/sdk-ts/src/client/indexer/types/mito.ts Updated MitoIDO interface to include projectDescription: string and isPermissionless: boolean.

Poem

In the garden of code, where rabbits play,
New fields sprout forth, brightening the day.
With descriptions and flags, our structures now sing,
Upgrading the paths that our packages bring.
Hop along, friends, let the updates unfold,
In the world of the code, new stories are told! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 96c0a35 and 9ed8d11.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • packages/sdk-ts/package.json (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcMitoTransformer.ts (1)

363-367: LGTM: Updated transformer with new fields

The transformer correctly maps the new fields from the proto model. Consider grouping related fields together for better readability (e.g., moving projectDescription next to other descriptive fields).

 return {
   name: IDO.name,
   owner: IDO.owner,
   status: IDO.status,
   marketId: IDO.marketId,
   tokenPrice: IDO.tokenPrice,
   quoteDenom: IDO.quoteDenom,
   useWhitelist: IDO.useWhitelist,
   vaultAddress: IDO.vaultAddress,
   capPerAddress: IDO.capPerAddress,
   contractAddress: IDO.contractAddress,
   subscribedAmount: IDO.subscribedAmount,
+  projectDescription: IDO.projectDescription,
   isPermissionless: IDO.isPermissionless,
   isLaunchWithVault: IDO.isLaunchWithVault,
   targetAmountInUsd: IDO.targetAmountInUsd,
   projectTokenAmount: IDO.projectTokenAmount,
-  projectDescription: IDO.projectDescription,
   isAccountWhiteListed: IDO.isAccountWhiteListed,
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2294fe9 and 96c0a35.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • packages/sdk-ts/package.json (1 hunks)
  • packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcMitoTransformer.ts (1 hunks)
  • packages/sdk-ts/src/client/indexer/types/mito.ts (1 hunks)
🔇 Additional comments (2)
packages/sdk-ts/package.json (1)

48-48: LGTM: Package version bump

The update from 1.13.0 to 1.13.2 of @injectivelabs/mito-proto-ts aligns with the new fields being added to the MitoIDO interface.

packages/sdk-ts/src/client/indexer/types/mito.ts (1)

243-244: LGTM: New MitoIDO fields

The addition of projectDescription and isPermissionless fields enhances the IDO information model with useful metadata. The field names are descriptive and the types are appropriate.

@ThomasRalee ThomasRalee merged commit 27c7199 into dev Dec 3, 2024
3 checks passed
@ThomasRalee ThomasRalee deleted the feat/update-mito-indexer branch December 3, 2024 10:29
@coderabbitai coderabbitai bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant