-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update mito indexer vesion #524
Conversation
Caution Review failedThe pull request is closed. WalkthroughThis pull request includes updates to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcMitoTransformer.ts (1)
363-367
: LGTM: Updated transformer with new fieldsThe transformer correctly maps the new fields from the proto model. Consider grouping related fields together for better readability (e.g., moving
projectDescription
next to other descriptive fields).return { name: IDO.name, owner: IDO.owner, status: IDO.status, marketId: IDO.marketId, tokenPrice: IDO.tokenPrice, quoteDenom: IDO.quoteDenom, useWhitelist: IDO.useWhitelist, vaultAddress: IDO.vaultAddress, capPerAddress: IDO.capPerAddress, contractAddress: IDO.contractAddress, subscribedAmount: IDO.subscribedAmount, + projectDescription: IDO.projectDescription, isPermissionless: IDO.isPermissionless, isLaunchWithVault: IDO.isLaunchWithVault, targetAmountInUsd: IDO.targetAmountInUsd, projectTokenAmount: IDO.projectTokenAmount, - projectDescription: IDO.projectDescription, isAccountWhiteListed: IDO.isAccountWhiteListed,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (3)
packages/sdk-ts/package.json
(1 hunks)packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcMitoTransformer.ts
(1 hunks)packages/sdk-ts/src/client/indexer/types/mito.ts
(1 hunks)
🔇 Additional comments (2)
packages/sdk-ts/package.json (1)
48-48
: LGTM: Package version bump
The update from 1.13.0
to 1.13.2
of @injectivelabs/mito-proto-ts
aligns with the new fields being added to the MitoIDO interface.
packages/sdk-ts/src/client/indexer/types/mito.ts (1)
243-244
: LGTM: New MitoIDO fields
The addition of projectDescription
and isPermissionless
fields enhances the IDO information model with useful metadata. The field names are descriptive and the types are appropriate.
Summary by CodeRabbit
isPermissionless
andprojectDescription
.@injectivelabs/mito-proto-ts
package.