Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cosmostation wallet support deposits #533

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

shane-moore
Copy link
Collaborator

@shane-moore shane-moore commented Dec 26, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced wallet strategy to support Cosmos blockchain
    • Added dynamic chain name detection for Cosmostation wallet
    • Expanded chain ID support across wallet implementations
  • Improvements

    • Increased flexibility for handling different blockchain types
    • Improved compatibility with multiple wallet strategies

@shane-moore shane-moore marked this pull request as draft December 26, 2024 20:58
Copy link

coderabbitai bot commented Dec 26, 2024

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/wallets/wallet-base/src/base.ts

Oops! Something went wrong! :(

ESLint: 7.32.0

Error: Error while loading rule 'jest/unbound-method': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
Occurred while linting /packages/wallets/wallet-base/src/base.ts
at throwError (/node_modules/@typescript-eslint/utils/dist/eslint-utils/getParserServices.js:39:11)
at getParserServices (/node_modules/@typescript-eslint/utils/dist/eslint-utils/getParserServices.js:31:9)
at create (/node_modules/@typescript-eslint/eslint-plugin/dist/rules/unbound-method.js:116:55)
at Object.create (/node_modules/@typescript-eslint/utils/dist/eslint-utils/RuleCreator.js:38:20)
at create (/node_modules/eslint-plugin-jest/lib/rules/unbound-method.js:47:88)
at Object.create (/node_modules/eslint-plugin-jest/node_modules/@typescript-eslint/utils/dist/eslint-utils/RuleCreator.js:41:20)
at createRuleListeners (/node_modules/eslint/lib/linter/linter.js:765:21)
at /node_modules/eslint/lib/linter/linter.js:937:31
at Array.forEach ()
at runRules (/node_modules/eslint/lib/linter/linter.js:882:34)

Walkthrough

The changes introduce enhanced support for Cosmos blockchain in the wallet infrastructure. The modifications span across multiple packages, focusing on expanding type definitions and adding flexibility to handle different blockchain chain IDs. The updates primarily involve updating constructor signatures, adding type support for Cosmos-specific chain IDs, and implementing a dynamic chain name extraction mechanism for the Cosmostation wallet strategy.

Changes

File Change Summary
packages/wallets/wallet-base/src/base.ts - Added CosmosChainId import
- Updated chainId type to support ChainId | CosmosChainId
- Expanded constructor to accept ConcreteCosmosWalletStrategyArgs
packages/wallets/wallet-cosmos/src/strategy/strategy.ts - Updated constructor to accept ChainId | CosmosChainId
packages/wallets/wallet-cosmostation/src/strategy/strategy.ts - Added getChainNameFromChainId method
- Added chainName public property
- Updated constructor to accept ChainId | CosmosChainId
- Replaced hardcoded chain names with dynamic this.chainName

Sequence Diagram

sequenceDiagram
    participant WalletBase
    participant CosmosStrategy
    participant Cosmostation

    WalletBase->>CosmosStrategy: Initialize with ChainId/CosmosChainId
    CosmosStrategy->>Cosmostation: Pass ChainId/CosmosChainId
    Cosmostation->>Cosmostation: Determine chainName dynamically
    Cosmostation-->>CosmosStrategy: Wallet Strategy Ready
Loading

Poem

🚀 Cosmos Wallets, Hopping Free

A rabbit's tale of blockchain glee
Chain IDs dancing, types expand
Flexibility across the land

Cosmostation leaps with might! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5527b3d and 0f1bb9d.

📒 Files selected for processing (3)
  • packages/wallets/wallet-base/src/base.ts (1 hunks)
  • packages/wallets/wallet-cosmos/src/strategy/strategy.ts (1 hunks)
  • packages/wallets/wallet-cosmostation/src/strategy/strategy.ts (8 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ThomasRalee ThomasRalee marked this pull request as ready for review January 8, 2025 08:06
@ThomasRalee ThomasRalee merged commit 46ab2b1 into dev Jan 8, 2025
3 checks passed
@ThomasRalee ThomasRalee deleted the chore/wallet-cosmostation-for-deposits branch January 8, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants