-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cosmostation wallet support deposits #533
Conversation
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/wallets/wallet-base/src/base.tsOops! Something went wrong! :( ESLint: 7.32.0 Error: Error while loading rule 'jest/unbound-method': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser. WalkthroughThe changes introduce enhanced support for Cosmos blockchain in the wallet infrastructure. The modifications span across multiple packages, focusing on expanding type definitions and adding flexibility to handle different blockchain chain IDs. The updates primarily involve updating constructor signatures, adding type support for Cosmos-specific chain IDs, and implementing a dynamic chain name extraction mechanism for the Cosmostation wallet strategy. Changes
Sequence DiagramsequenceDiagram
participant WalletBase
participant CosmosStrategy
participant Cosmostation
WalletBase->>CosmosStrategy: Initialize with ChainId/CosmosChainId
CosmosStrategy->>Cosmostation: Pass ChainId/CosmosChainId
Cosmostation->>Cosmostation: Determine chainName dynamically
Cosmostation-->>CosmosStrategy: Wallet Strategy Ready
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
New Features
Improvements