Fix isClear for singleDatePicker #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside isClear computed property, don't check if endDate is set when using singleDatePicker. Without this fix, the dateRange.startDate does not properly set this.start data property. To reproduce the issue, programmatically toggle the picker with singleDatePicker and initial property without endDate set. You will see that the passed in startDate date and time are not selected in the popup. To verify this issue, if you set the endDate to new Date(), then date and time are properly selected on picker toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside isClear computed property, don't check if endDate is set when using singleDatePicker.
Without this fix, the dateRange.startDate does not properly set this.start data property.
To reproduce the issue, programmatically toggle the picker with singleDatePicker and initial property without endDate set.
You will see that the passed in startDate date and time are not selected in the popup.
To verify this issue, if you set the endDate to
new Date(), then date and time are properly selected on picker toggle.