feat: Using Block Registry to Replace Iterating Over the Material Enum #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would point out that (iirc) Spigot (and paper) plan to replace enums for materials with a registry of similar sorts (this has already been done for biomes). |
|
I assume this is supposed to fix #3060? In that case, I'd be fine with the change, at least until spigot marks it BlockType class/Block registry as non-internal. |
I'm not sure, I feel we'd have more reports if there was a consistent issue? It should only be an issue if Spigot/Paper have stopped maintaining the Material enum for some reason... Regardless, the API-breaking change needs to go |
dordsor21
requested changes
Jan 11, 2025
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BlockRegistry.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Material in Bukkit is an enum, which is not very flexible. This PR replaces it with Minecraft's built-in block registry to reduce unnecessary checks. Additionally, it changes values() to getAllDefaultBlockStates() to improve readability.