Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WO4You URL #815

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Added WO4You URL #815

merged 2 commits into from
Mar 18, 2024

Conversation

SimplyPancake
Copy link
Contributor

Please add the following information to your pull request:

Please describe what your PR is fixing
This PR adds the book URL of WO4You, such that signed in members can view it.
This URL is in the local.py and also added in generic.py

Concretely, which issues does your PR solve? (Please reference them by typing Fixes/References Inter-Actief/amelie#<issue_id>)
Fixes/References #807

Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no

Does your PR include any django migrations?
no

Does your PR include the proper translations (did you add translations for new/modified strings)?
yes, I have included the translations

Does your PR include CSS changes (and did you run the compile_css.sh script in the scripts directory to regenerate the compiled.css file)?
no, my PR does not include CSS changes

Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
yes! It has a new (local) variable. The URL that you need is provided in the issue

Did you properly test your PR before submitting it?
yes

@SimplyPancake SimplyPancake linked an issue Oct 30, 2023 that may be closed by this pull request
@Kurocon Kurocon merged commit 77832ba into main Mar 18, 2024
5 checks passed
@Kurocon Kurocon deleted the 807-new-wo4you-link-for-members-only branch March 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New WO4You link for members only
2 participants