Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

719: Order photos by creation time. #840

Merged

Conversation

20Thomas02
Copy link
Contributor

Previously the albums were effectively randomly sorted. Now we look at the creation time in the database. This is not perfect if we want to order on when a photo was taken, but it is a lot better than before at no significant performance penalty or database change.

Please add the following information to your pull request:

Please describe what your PR is fixing
Previously the albums were effectively randomly sorted. Now we look at
the creation time in the database. This is not perfect if we want to
order on when a photo was taken, but it is a lot better than before at
no significant performance penalty or database change.

Concretely, which issues does your PR solve? (Please reference them by typing Fixes/References Inter-Actief/amelie#<issue_id>)
Fixes Inter-Actief/amelie#719

Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no

Does your PR include any django migrations?
no

Does your PR include the proper translations (did you add translations for new/modified strings)?
no, my PR does not include translations

Does your PR include CSS changes (and did you run the compile_css.sh script in the scripts directory to regenerate the compiled.css file)?
no, my PR does not include CSS changes

Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no

Did you properly test your PR before submitting it?
yes, I checked activity 6776 on the beta server and the first 16 photos were correctly sorted looking at the logged file path which included timestamps (when the photo was taken probably), and an incrementing image number that looked good.

Previously the albums were effectively randomly sorted. Now we look at
the creation time in the database. This is not perfect if we want to
order on when a photo was taken, but it is a lot better than before at
no significant performance penalty or database change.
@Kurocon Kurocon merged commit dd2e559 into Inter-Actief:main Mar 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants