719: Order photos by creation time. #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the albums were effectively randomly sorted. Now we look at the creation time in the database. This is not perfect if we want to order on when a photo was taken, but it is a lot better than before at no significant performance penalty or database change.
Please add the following information to your pull request:
Please describe what your PR is fixing
Previously the albums were effectively randomly sorted. Now we look at
the creation time in the database. This is not perfect if we want to
order on when a photo was taken, but it is a lot better than before at
no significant performance penalty or database change.
Concretely, which issues does your PR solve? (Please reference them by typing
Fixes/References Inter-Actief/amelie#<issue_id>
)Fixes Inter-Actief/amelie#719
Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no
Does your PR include any django migrations?
no
Does your PR include the proper translations (did you add translations for new/modified strings)?
no, my PR does not include translations
Does your PR include CSS changes (and did you run the
compile_css.sh
script in thescripts
directory to regenerate thecompiled.css
file)?no, my PR does not include CSS changes
Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no
Did you properly test your PR before submitting it?
yes, I checked activity 6776 on the beta server and the first 16 photos were correctly sorted looking at the logged file path which included timestamps (when the photo was taken probably), and an incrementing image number that looked good.