Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made JS module not be compressed, as it would not be a module anymore #852

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

SimplyPancake
Copy link
Contributor

Please add the following information to your pull request:

Please describe what your PR is fixing
JS Was compressed on production, making the JS module not a JS module anymore and breaking the code.

Concretely, which issues does your PR solve? (Please reference them by typing Fixes/References Inter-Actief/amelie#<issue_id>)
#851

Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no

Does your PR include any django migrations?
no

Does your PR include the proper translations (did you add translations for new/modified strings)?
no, my PR does not include translations

Does your PR include CSS changes (and did you run the compile_css.sh script in the scripts directory to regenerate the compiled.css file)?
no, my PR does not include CSS changes

Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no

Did you properly test your PR before submitting it?
yes

@SimplyPancake SimplyPancake linked an issue Apr 17, 2024 that may be closed by this pull request
@Kurocon Kurocon merged commit 00550b1 into main Apr 17, 2024
6 of 10 checks passed
@Kurocon Kurocon deleted the 851-cb-script-not-working-due-to-module branch April 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CB Script not working due to module
2 participants