890 room duty committee rights #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyPancake
approved these changes
Sep 9, 2024
Kurocon
requested changes
Sep 9, 2024
…or in favor of directly using the `require_committee` decorator, make roomduty checks that use the RequireCommitteeMixin use the setting `ROOM_DUTY_ABBREVIATION`. Refactor `require_committee` decorator, `RequireCommitteeMixin` mixin and `RequireStrictCommitteeMixin` mixin to use the new Person.is_in_committee method.
Kurocon
approved these changes
Sep 16, 2024
…e `Person.is_in_committee` where possible.
Kurocon
force-pushed
the
890-room-duty-committee-rights
branch
from
4dafb60 to
5592657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add the following information to your pull request:
Please describe what your PR is fixing
Fix issue
Concretely, which issues does your PR solve? (Please reference them by typing
Fixes/References Inter-Actief/amelie#<issue_id>)Fixes issue #890
Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no
Does your PR include any django migrations?
no
Does your PR include the proper translations (did you add translations for new/modified strings)?
no, my PR does not include translations
Does your PR include CSS changes (and did you run the
compile_css.shscript in thescriptsdirectory to regenerate thecompiled.cssfile)?no, my PR does not include CSS changes
Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no
Did you properly test your PR before submitting it?
yes