Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure pre commit hooks in CI #106

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Configure pre commit hooks in CI #106

merged 2 commits into from
Dec 28, 2023

Conversation

mohamedawnallah
Copy link
Member

@mohamedawnallah mohamedawnallah commented Dec 27, 2023 •
edited
Loading

Description

Configure per-commit hooks in the CI.

Motivation and Context

We should automatically run the pre-commit hooks which are configured in .pre-commit-config.yml in the CI.

How Has This Been Tested?

Please check the latest GitHub action job result:
https://github.com/InternetHealthReport/internet-yellow-pages/actions/runs/7335524440

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@m-appel m-appel merged commit 76ea12e into InternetHealthReport:main Dec 28, 2023
1 check passed
@mohamedawnallah mohamedawnallah deleted the configure-precommit-ci-hooks branch January 4, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-appel m-appel Awaiting requested review from m-appel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedawnallah @m-appel