decompressed roas.csv.xz and changed the urls #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-appel and @romain-fontugne can you review my PR :-) |
|
Hey, your PR looks good to me, please just fix the formatting (easiest is to setup |
pre-commit
passed all test
|
@m-appel I have modified the code struct, It passed all the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solved the issue of #117
Description
In this modification, requests.get() is used to fetch the .xz file content. Then, the content is decompressed using lzma.open() and read as a CSV file. The rest of the code remains the same as before for processing the CSV data.
Motivation and Context
Types of changes
Checklist: