Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rov detection #83 issue #124

Merged
merged 22 commits into from
Feb 9, 2024
Merged

Conversation

MAVRICK-1
Copy link
Contributor

@MAVRICK-1 MAVRICK-1 commented Feb 7, 2024

Description

Solved the #83

Motivation and Context

Create working crawler for Rov.
RoV Scores are based on the number of RPKI-invalid prefixes reachable by an Autonomous System (AS). A higher RoV score indicates better filtering of RPKI-invalid prefixes. However, the score doesn't confirm ROV implementation due to framework limitations and other factors. IYP tags ASes with a ratio > 0.5 as Validating RPKI ROV and ≤ 0.5 as Not Validating RPKI ROV.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@m-appel I had a pre-commit issue with the previous branch
so I closed that Pull request

@m-appel m-appel self-requested a review February 8, 2024 01:41
@m-appel m-appel linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link
Member

@m-appel m-appel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, you have a working crawler! :)

I've commented on a few nitpicks, once these are done this PR is good to be merged.

Btw. have you installed pre-commit locally? It should report the same problems as the GitHub runner when you commit, i.e., you do not have to wait for the output of the runner.

iyp/crawlers/rovista/validating_rov.py Outdated Show resolved Hide resolved
logging.info('Pushing nodes to neo4j...\n')
# get ASNs and prefixes IDs
self.asn_id = self.iyp.batch_get_nodes_by_single_prop('AS', 'asn', asns)
tag_id_not_vali = self.iyp.get_node('Tag', {'label': 'Not Validating RPKI ROV'}, create=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag_id_not_valid (d is missing)

iyp/crawlers/rovista/validating_rov.py Outdated Show resolved Hide resolved
iyp/crawlers/rovista/validating_rov.py Outdated Show resolved Hide resolved
iyp/crawlers/rovista/validating_rov.py Outdated Show resolved Hide resolved
iyp/crawlers/rovista/validating_rov.py Outdated Show resolved Hide resolved
@MAVRICK-1
Copy link
Contributor Author

@m-appel Thanks for Your Guidance , I made the requested changes , and Sry for the numerous commits , I am new to using pre-commit . In the Future , I will strive to minimize the frequency of commits

@MAVRICK-1 MAVRICK-1 requested a review from m-appel February 8, 2024 04:06
@MAVRICK-1
Copy link
Contributor Author

Congratulations, you have a working crawler! :)

I've commented on a few nitpicks, once these are done this PR is good to be merged.

Btw. have you installed pre-commit locally? It should report the same problems as the GitHub runner when you commit, i.e., you do not have to wait for the output of the runner.

Have installed it but it's showing

pre-commit : The term 'pre-commit' is not recognized as the name of a cmdlet, function, 
script file, or operable program. Check the spelling of the name, or if a path was included, 
verify that the path is correct and try again.

Copy link
Member

@m-appel m-appel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me now!

@m-appel m-appel merged commit 05e9276 into InternetHealthReport:main Feb 9, 2024
1 check passed
@MAVRICK-1 MAVRICK-1 deleted the Rov-Detection branch February 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoVista RoV detection
2 participants