-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rov detection #83 issue #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations, you have a working crawler! :)
I've commented on a few nitpicks, once these are done this PR is good to be merged.
Btw. have you installed pre-commit locally? It should report the same problems as the GitHub runner when you commit, i.e., you do not have to wait for the output of the runner.
logging.info('Pushing nodes to neo4j...\n') | ||
# get ASNs and prefixes IDs | ||
self.asn_id = self.iyp.batch_get_nodes_by_single_prop('AS', 'asn', asns) | ||
tag_id_not_vali = self.iyp.get_node('Tag', {'label': 'Not Validating RPKI ROV'}, create=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag_id_not_valid
(d
is missing)
@m-appel Thanks for Your Guidance , I made the requested changes , and Sry for the numerous commits , I am new to using pre-commit . In the Future , I will strive to minimize the frequency of commits |
Have installed it but it's showing
|
…operty precommit-resolved
…pages into Rov-Detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me now!
Description
Solved the #83
Motivation and Context
Create working crawler for Rov.
RoV Scores are based on the number of RPKI-invalid prefixes reachable by an Autonomous System (AS). A higher RoV score indicates better filtering of RPKI-invalid prefixes. However, the score doesn't confirm ROV implementation due to framework limitations and other factors. IYP tags ASes with a ratio > 0.5 as Validating RPKI ROV and ≤ 0.5 as Not Validating RPKI ROV.
Screenshots (if appropriate):
Types of changes
Checklist:
@m-appel I had a pre-commit issue with the previous branch
so I closed that Pull request