Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenINTEL rDNS crawler and rename dns_dependency crawler to dnsgraph #130

Merged

Conversation

m-appel
Copy link
Member

@m-appel m-appel commented Feb 22, 2024

We have an additional dataset that is based on rDNS data (which will be implemented via a different PR). Also we were not happy with the name of the dns_dependency crawler, so we renamed it.

How Has This Been Tested?

I ran the dnsgraph_rdns crawler once, the rest is only refactoring.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@romain-fontugne
Copy link
Member

thanks!

@romain-fontugne romain-fontugne merged commit 694415e into InternetHealthReport:main Feb 26, 2024
1 check passed
@m-appel m-appel deleted the dns-dependency-rename branch November 15, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants