Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #129 #132

Merged

Conversation

JustinLoye
Copy link
Contributor

World Bank crawler to get countries' population, closes issue #129

Description

Connect Country to an Estimate node meaning that a country has an estimated population of value.

(:Country)-[:POPULATION {value: 123}]->(:Estimate {name: 'World Bank Population Estimate'})

Motivation and Context

It could be useful to have the countries' population. For example the ranking ihr.country_dependency gives the relative population coverage of eyeball networks per country, but does not indicate the actual population value.

How Has This Been Tested?

I checked the overall number of countries and the values of the most populated ones.

Screenshots (if appropriate):

10 most populated countries
top10_pop

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@m-appel m-appel self-requested a review March 7, 2024 02:14
@m-appel m-appel linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Member

@m-appel m-appel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, see comments for nitpicks. And you should add the crawler to config.json.example, probably below the Alive-LG crawlers.

iyp/crawlers/worldbank/country_pop.py Outdated Show resolved Hide resolved
iyp/crawlers/worldbank/country_pop.py Outdated Show resolved Hide resolved
iyp/crawlers/worldbank/README.md Outdated Show resolved Hide resolved
Copy link
Member

@m-appel m-appel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@m-appel m-appel merged commit 32f973d into InternetHealthReport:main Mar 11, 2024
1 check passed
@JustinLoye JustinLoye deleted the issue-129/worldbank-countrypop branch March 14, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add country population from World Bank
2 participants