Fix BGP.Tools AS names crawler #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a format change, the previous version was broken. We now use pandas to parse the CSV and be robust against future format changes. The current change also added a class field which is similar to a tag, which we now also import. We do not import the country code field, since we do not know where it comes from and will probably just add redundant information.
romain-fontugne
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a format change, the previous version was broken. We now use pandas to parse the CSV and be robust against future format changes. The current change also added a class field which is similar to a tag, which we now also import.
We do not import the country code field, since we do not know where it comes from and will probably just add redundant information.
Motivation and Context
Closes #133.
How Has This Been Tested?
Full run of the crawler.
Types of changes
Checklist: