Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Citizen Lab crawler #135

Merged

Conversation

m-appel
Copy link
Member

@m-appel m-appel commented Mar 15, 2024

Description

This crawler did not handle the header of the country code CSV files correctly and created a URL and Tag node consisting of the header fields.
This refactor uses pandas to parse the CSV file and also removes logging to stderr.

How Has This Been Tested?

Rerun of the crawler.

Screenshots (if appropriate):

MATCH p = (:URL)-[:CATEGORIZED {reference_name: 'citizenlab.urldb'}]->(:Tag {label: 'category_description'})
RETURN p

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This crawler did not handle the header of the country code CSV files
correctly and created a URL and Tag node consisting of the header
fields.
This refactor uses pandas to parse the CSV file and also removes logging
to stderr.
@m-appel m-appel requested a review from romain-fontugne March 15, 2024 05:30
Copy link
Member

@romain-fontugne romain-fontugne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@romain-fontugne romain-fontugne merged commit 90e35c3 into InternetHealthReport:main Mar 18, 2024
1 check passed
@m-appel m-appel deleted the refactor-citizenlab branch November 15, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants