Logging rework #141
Merged
Logging rework #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All crawlers now log only using the logging module and not using stderr
anymore. Also the IYP module now automatically logs node/relationship
retrieval and creation. As a consequence, some crawlers are a bit
chatty, which should be fixed in the future.
The general log level was changed to INFO and the level name is now
included in the logs instead of the process name.
As parts of this also some crawlers got reworked:
- alice_lg: Fixed unit test that checked for relationship types which
are not created.
- ihr:
- Reference modification time is more precise, matching the exact
timebin used
- Data is handled in-memory, removing need for temporary files
- Moved to batch creation, making the crawler faster and removing
dependency on other crawlers
romain-fontugne
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All crawlers now log only using the logging module and not using stderr anymore. Also the IYP module now automatically logs node/relationship retrieval and creation. As a consequence, some crawlers are a bit chatty, which should be fixed in the future.
The general log level was changed to INFO and the level name is now included in the logs instead of the process name.
As parts of this also some crawlers got reworked: