Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modification time to AS Rank crawler #142

Conversation

m-appel
Copy link
Member

@m-appel m-appel commented Sep 13, 2024

Description

CAIDA now provides a dataset endpoint in their REST API that includes the update times of the datasets, which we can now include.

Motivation and Context

Closes #140.

How Has This Been Tested?

Ran caida.as_rank and confirmed existence of modification time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@m-appel
Copy link
Member Author

m-appel commented Sep 13, 2024

Looks good to me.

@m-appel m-appel merged commit e9a7b49 into InternetHealthReport:main Sep 13, 2024
1 check passed
@m-appel m-appel deleted the 140-add-reference_time_modification-to-as-rank-crawler branch November 15, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reference_time_modification to AS Rank crawler.
1 participant