Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework OONI crawlers #152

Merged

Conversation

m-appel
Copy link
Member

@m-appel m-appel commented Nov 18, 2024

This is a general rework of the OONI crawlers, fixing some issues and sliming down the code.

Description

ToDo

Motivation and Context

Closes #148

How Has This Been Tested?

Full run of all crawlers and individual ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@romain-fontugne
Copy link
Member

thanks!

@romain-fontugne romain-fontugne marked this pull request as ready for review November 19, 2024 03:57
@m-appel m-appel marked this pull request as draft November 19, 2024 03:59
- Keep category names close to the documentation
- All categories in lower case
- Fix some more counting issues
@m-appel m-appel marked this pull request as ready for review November 28, 2024 06:23
@m-appel
Copy link
Member Author

m-appel commented Nov 28, 2024

This should be ready now @romain-fontugne can you take a look at the documentation updates before merging? Thanks

@romain-fontugne
Copy link
Member

Thanks, looks good to me. Nice readme :)

@romain-fontugne romain-fontugne merged commit b8212ac into InternetHealthReport:main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OONI scrubbed IPs
2 participants