Add crawler for Google's CrUX top 1M per country #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create everything in one batch - Fix: reference time now points to the first day of the month at midnight - Fix: reference time needs to be a datetime object, not Arrow - Fix: fetch the newest data, not the oldest - Make data URL more precise - Add country code to RANK relationship - Use itertuples instead of iterrows since it is faster - Add COUNTRY relationship check to unit test - Change log level to INFO - Fix typos and consistency in README
m-appel
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Google's CrUX top 1M as discussed here: #153
Slightly different modeling, I just simplified the properties of the RANK relationship. It includes on the
rankandorigin.How Has This Been Tested?
Tested locally, it took over 1.5 hours to run. But after all this is a fairly big dataset containing 200+ 1M top lists.
Types of changes
Checklist: