Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenINTEL crawler #162

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

m-appel
Copy link
Member

@m-appel m-appel commented Dec 12, 2024

Better handling for CNAMEs. Previously we treated them as chains, but they are more like trees.

Description

Instead of assuming straight chains we now do a depth-first traversal to find all valid RESOLVES_TO relationships.

Motivation and Context

The initial version of this assumed that each query can only have a straight CNAME chain to one or more A/AAAA records. However, there are cases where the chain branches, i.e., one name has multiple CNAME records, or even a name having both a CNAME and an A/AAAA record.

How Has This Been Tested?

Full run of all instances of OpenIntelCrawler

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Better handling for CNAMEs. Previously we treated them as chains, but
they are more like trees.
@m-appel m-appel merged commit d21d96c into InternetHealthReport:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant