Update Cloudflare crawler #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create parent class from which both crawlers inherit, replacing the model in which one crawler inherited from another - Actually fetch in batches and also in parallel, speeding up the process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Crawler is pretty slow and most of its runtime is spend downloading. Parallel downloads and batches make things faster.
How Has This Been Tested?
Tried multiple times with different batch sizes / parallel downloads and the current settings (batches of 10; 4 parallel downloads) seem to work without issue (i.e., hitting rate limits or timeouts).
Types of changes
Checklist: