Query function rework #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reworks the main functions used to query/create nodes.
Both get_node and batch_get_nodes functions now have a similar interface
and behavior.
Added support for multi-label nodes.
- batch_get_nodes_by_single_prop
- Renamed from batch_get_nodes
- Added create parameter for consistency
- get_node
- Change default value of create parameter to True. There was no
instance where this function was called with create=False and now it
is consistent with batch_get_nodes.
- Change interface to be the same as batch_get_nodes.
- Id properties used as the search predicate must now be specified
explicitly instead of being inferred from constraints.
- batch_get_nodes
- New function that supports querying/creating nodes with multiple
properties, where as subset of the properties can be used as the
search predicate.
- batch_add_node_label
- New function to add additional labels to existing nodes.
- batch_create_nodes
- Deleted due to inflexibility and danger of creating duplicate nodes.
Remove explicit constraints and indexes since these would need manual updates every time we add a new node or relationship type. Instead, we now automatically create UNIQUE constraints based on the id properties used to create nodes. The rationale is that we (at least in the context of crawlers) always get nodes based on unique properties. If there are conflicts introduced by this is should only reveal problems in our existing code. Similarly, we now also create an index on the reference_name field of all relationship types automatically, since this is used very often and exists for all relationship types.
|
I tried and it seemed to have worked as expected. thanks! |
|
ah, I think the version I tried didn't have the constrains and indexes. I'll try again before merging |
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the main functions used to query/create nodes. Both get_node and batch_get_nodes functions now have a similar interface and behavior.
Added support for multi-label nodes.