Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the IANA root zone file crawler and closes #82. Since this is the first crawler that adds multi-label nodes, additional changes to the OpenINTEL crawlers were required to prevent conflicts.
Description
The IANA root zone file contains NS records for the top-level domains, as well as A/AAAA records for the authoritative name servers.
This is the first crawler that introduces multi-label nodes, namely we now have a combination
DomainName:AuthoritativeNameServer
, since every name server is identified by a domain name. In accordance with this change, this PR updates the other crawler that createsAuthoritativeNameServer
nodes, namely the OpenINTEL crawler. Without this change there are conflicting constraints.As part of changing the OpenINTEL crawler this PR also reduces the execution time of the link-computation phase of the crawler by a factor of 10. The current version used an inefficient method for iterating over the data.
How Has This Been Tested?
These changes have been tested as part of a full database creation and also repeated independently.
Types of changes
Checklist: