Update Atlas probe crawler to fetch all probes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the planned measurement crawler it is required to have more than only the connected probes in the graph. Especially long-running measurements can contain disconnected probes, but we might still want to model them. Note that this crawler can now create dangling nodes, e.g., there is a status "Never Connected" where the probes have no IP/ASN/country. But instead of arbitrarily deciding what to include and what not, we just fetch all (public) probes instead, since the number is not very large. This commit also updates the IPv6 handling to guarantee a canonical form.
romain-fontugne
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the planned measurement crawler it is required to have more than only the connected probes in the graph. Especially long-running measurements can contain disconnected probes, but we might still want to model them.
Note that this crawler can now create dangling nodes, e.g., there is a status "Never Connected" where the probes have no IP/ASN/country. But instead of arbitrarily deciding what to include and what not, we just fetch all (public) probes instead, since the number is not very large.
This commit also updates the IPv6 handling to guarantee a canonical form.
How Has This Been Tested?
Deleted all Atlas probes from a current dump and ran the crawler.
Types of changes
Checklist: