Refactoring batch_format_link_properties
to Utilize Optional Return Type for in-place Mutation
#96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current functionality within
batch_format_link_properties
doesn't utilize the returned links when theinplace
parameter is set toTrue
. It's more conventionally sound not to return a value if we're already mutating in place.Changes Made
batch_format_link_properties
when theinplace
parameter isTrue
.Optional
from thetyping
module to denote the possible absence of a return value wheninplace
is set toTrue
.How Has This Been Tested?
No alterations to the logic's behavior have been made. Testing ensured that the removal of the return value was correctly implemented, specifically when the
inplace
parameter isTrue
.Additional References
Python Optional typing hint:
https://docs.python.org/3/library/typing.html#typing.Optional
Types of changes
Checklist: