Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin publish and update dependencies #86

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

cortlepp
Copy link
Contributor

@cortlepp cortlepp commented Nov 27, 2023

  • fix plugin publish config
  • update other dependencies (I did not update "com.bmuschko:gradle-docker-plugin because doing so would require a lot of additional work and is out of scope for this PR)

Note that due to an update of the detekt config it became apparent that our current configuration for formatting was never active. Fixing this is out of scope for this PR, so I disabled the formatting rules.

Copy link

github-actions bot commented Nov 27, 2023

Test Results

23 tests  ±0   21 ✔️ ±0   2m 32s ⏱️ +3s
  5 suites ±0     2 💤 ±0 
  5 files   ±0     0 ±0 

Results for commit fd5f9ad. ± Comparison against base commit a9a1a0b.

♻️ This comment has been updated with latest results.

@cortlepp
Copy link
Contributor Author

@DevDavido I talked to @m-raab and he says its our decision what we want to do with detekt. I also took another look at the plugin, my findings:

  • there is an option to auto correct the findings with ./gradlew detekt --auto-correct. This doesn't fix all findings though, even if you configure it in detekt.yml
  • even if we did get it to work, I don't think it's worth the effort. It just leads to more work, with the benefit of having slightly prettier code, and even that is debatable
  • detekt can also do more static code analysis I think, but configuring and using this properly would require more effort than we are currently willing to put into this project

So, my proposal: remove the detekt plugin and detekt.yml without a replacement.

@cortlepp cortlepp merged commit 8ea88c7 into master Nov 28, 2023
2 checks passed
@m-raab m-raab deleted the bugfix/core/plugin-publish branch November 28, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant