fix: move user setting to mail server, add test #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiesewetter-intershop
requested changes
Nov 30, 2023
| @@ -42,6 +44,13 @@ class TaskPreparer(project: Project, | |||
|
|
|||
| project.tasks.register ("start${getExtensionName()}", StartExtraContainer::class.java) { task -> | |||
| configureContainerTask(task) | |||
|
|
|||
| val os: OperatingSystem = DefaultNativePlatform.getCurrentOperatingSystem() | |||
There was a problem hiding this comment.
Using an internal class will make upgrade much trickier.
There was a problem hiding this comment.
Maybe alternatively use System.getProperty("os.name")?
There was a problem hiding this comment.
Yes, you are correct - it is internal and a method with System.getProperty is possible. I asked StackOverflow for an approach that is working on different OSs. This internal API is not the only one and I think they will create also an external API.
|
is fixed at master (skiesewetter) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.