-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update gradle to 8.5 (#92129) #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skiesewetter-intershop
commented
Jan 9, 2024
- update gradle to 8.5
- using JavaToolChain with Java 17
- replaced calls to deprecated code where possible
- removed scmversion-plugin
- removed detekt-plugin
- now using .github actions
- updated documentation
* update gradle to 8.5 * using JavaToolChain with Java 17 * replaced calls to deprecated code where possible * removed scmversion-plugin * removed detekt-plugin * now using .github actions * updated documentation
skiesewetter-intershop
requested review from
DevDavido,
Thomas-Bergmann,
stefanh1,
m-raab,
SteBoe82 and
cortlepp
January 9, 2024 14:59
skiesewetter-intershop
had a problem deploying
to
CIRelease
January 9, 2024 14:59 — with
GitHub Actions
Failure
Test Results23 tests ±0 21 ✅ ±0 1m 58s ⏱️ +5s Results for commit e030c7a. ± Comparison against base commit 684dbfd. This pull request removes 20 and adds 20 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
DevDavido
approved these changes
Jan 9, 2024
cortlepp
reviewed
Jan 10, 2024
cortlepp
approved these changes
Jan 10, 2024
skiesewetter-intershop
had a problem deploying
to
CIRelease
January 10, 2024 07:42 — with
GitHub Actions
Failure
* added docker preparation to workflows
skiesewetter-intershop
temporarily deployed
to
CIRelease
January 10, 2024 08:12 — with
GitHub Actions
Inactive
skiesewetter-intershop
temporarily deployed
to
CIRelease
January 10, 2024 08:12 — with
GitHub Actions
Inactive
* declared missing inputs in actions/prepare-docker/action.yaml
skiesewetter-intershop
temporarily deployed
to
CIRelease
January 10, 2024 08:21 — with
GitHub Actions
Inactive
skiesewetter-intershop
temporarily deployed
to
CIRelease
January 10, 2024 08:21 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.