Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use host user for mail container (#93663) #94

Merged

Conversation

skiesewetter-intershop
Copy link
Contributor

  • the mail container is now started using the host user by default
  • removed obsolete FIXME-comments

* the mail container is now started using the host user by default
* removed obsolete FIXME-comments
Copy link

github-actions bot commented Feb 14, 2024

Test Results

19 tests  ±0   17 ✅ ±0   1m 56s ⏱️ +3s
 5 suites ±0    2 💤 ±0 
 5 files   ±0    0 ❌ ±0 

Results for commit 237343f. ± Comparison against base commit 5ff18e6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@cortlepp cortlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that this should be addressed at some point. And there was also some more dead code.

But since both of these are unrelated to what you are doing here, its fine by me.

@skiesewetter-intershop skiesewetter-intershop merged commit afd6029 into master Feb 19, 2024
3 checks passed
@skiesewetter-intershop skiesewetter-intershop deleted the 93663-use-host-user-for-mail-container branch February 19, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants