Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

193 events hints #216

Merged
merged 17 commits into from
Jan 31, 2020
Merged

193 events hints #216

merged 17 commits into from
Jan 31, 2020

Conversation

IssaHanou
Copy link
Owner

@IssaHanou IssaHanou commented Jan 29, 2020 •
edited
Loading

closes #193 - its other points are put in new issues: #217, #218, #219

  • split general events and puzzles
  • rules per puzzles in table
  • hint selection per puzzle
  • hint sending per device
  • descriptions in popups (devices and rules)
  • hint customs per device
  • hint predefined from general box
  • hint log
  • device descriptions
  • camera consistency

home screen:
image

uitgevouwen:
image

camera consistent header
image

@IssaHanou IssaHanou changed the title 193 events hints WIP 193 events hints Jan 29, 2020
@IssaHanou IssaHanou changed the title WIP 193 events hints 193 events hints Jan 30, 2020
GwennanS
GwennanS reviewed Jan 30, 2020
View reviewed changes
back-end/src/sciler/config/configHandler.go Outdated Show resolved Hide resolved
cc_library/example_scripts_js_scc/display-node/browser-side.js Outdated Show resolved Hide resolved
front-end/src/app/app.component.ts Outdated Show resolved Hide resolved
@mrlomar
Copy link
Collaborator

mrlomar commented Jan 31, 2020 •
edited
Loading

Hints should be logged to the back-end, now when you refresh the operator screen the logs of the hints are forgotten.

I made an issue for this: #223

@mrlomar
Copy link
Collaborator

mrlomar commented Jan 31, 2020 •
edited
Loading

image

  1. can be left out since the title of this box is already puzzels
  2. should be 'regel' otherwise this might be confusing

(this also counts for the box 'gebeurtenissen')

@mrlomar mrlomar merged commit 4ec368f into develop-sprint-8 Jan 31, 2020
@mrlomar mrlomar deleted the 193-events-hints branch January 31, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GwennanS GwennanS GwennanS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve front-end >Lana
3 participants
@IssaHanou @mrlomar @GwennanS