feat(PodMetrics): optimize startup (#736)

IvanJosipovic · Sep 26, 2024 · 6bbbed4 · 6bbbed4
1 parent a9f08cf
commit 6bbbed4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 26 deletions.
diff --git a/src/KubeUI/App.axaml.cs b/src/KubeUI/App.axaml.cs
@@ -1,4 +1,5 @@
-using System.Reflection;
+using System;
+using System.Reflection;
 using System.Runtime.InteropServices;
 using Avalonia.Data.Core.Plugins;
 using Avalonia.Logging;
@@ -112,7 +113,7 @@ public override void Initialize()
                     .AddMeter(Instrumentation.MeterName)
                     .AddOtlpExporter((e, b) =>
                     {
-                        b.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = 60 * 1000; // 1 min
+                        b.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = (int)TimeSpan.FromMinutes(1).TotalMilliseconds;
                         e.Endpoint = new Uri("https://otel.kubeui.com/v1/metrics");
                         e.Headers = $"key={key}";
                         e.Protocol = OtlpExportProtocol.HttpProtobuf;

diff --git a/src/KubeUI/Controls/PodMetricCPUCell.cs b/src/KubeUI/Controls/PodMetricCPUCell.cs
@@ -15,18 +15,7 @@ public PodMetricCPUCell()
     {
         s_timer.Tick += Timer_Tick;
         s_timer.Interval = TimeSpan.FromSeconds(1);
-    }
-
-    protected override void OnDataContextChanged(EventArgs e)
-    {
-        base.OnDataContextChanged(e);
-
-        Update();
-
-        if (!s_timer.IsEnabled)
-        {
-            s_timer.Start();
-        }
+        s_timer.Start();
     }
 
     private void Timer_Tick(object? sender, EventArgs e)
@@ -80,5 +69,6 @@ protected override void OnUnloaded(RoutedEventArgs e)
     public void Initialize(ICluster cluster)
     {
         Cluster = cluster;
+        Update();
     }
 }
diff --git a/src/KubeUI/Controls/PodMetricMemoryCell.cs b/src/KubeUI/Controls/PodMetricMemoryCell.cs
@@ -16,18 +16,7 @@ public PodMetricMemoryCell()
     {
         s_timer.Tick += Timer_Tick;
         s_timer.Interval = TimeSpan.FromSeconds(1);
-    }
-
-    protected override void OnDataContextChanged(EventArgs e)
-    {
-        base.OnDataContextChanged(e);
-
-        Update();
-
-        if (!s_timer.IsEnabled)
-        {
-            s_timer.Start();
-        }
+        s_timer.Start();
     }
 
     private void Timer_Tick(object? sender, EventArgs e)
@@ -81,5 +70,6 @@ protected override void OnUnloaded(RoutedEventArgs e)
     public void Initialize(ICluster cluster)
     {
         Cluster = cluster;
+        Update();
     }
 }