-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor runtime to support AudioPlayer #306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the runtime so that the audio player can be used just as easily as the Canvas.
This is a large PR with a ton of changes:
CanvasManager
) were removed in favor of plainFunction0
RenderLoop
completely refactored:RenderLoop
renamed toAppLoop
Loop
class was removedImpureRenderLoop
/PureRenderLoop
distinction was removed. The effect is now picked automatically with aFrameEffect
typeclassState => Subsystem => Unit
instead of(Subsystem, State) => Unit
AppLoop.Definition
)MinartApp
moved frompure
tocore
, now it can also be used in impure programsAudioPlayerIO
operationsI'm not entirely happy with the results (namely, composing subsystems seems unnecessarily complex), but some of the changes seem to be on the right direction for #18